Michael Pasternak has posted comments on this change.
Change subject: restapi: Attaching a network to cluster by network id
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java
Line 47: }
Line 48:
Line 49: String networkId = null;
Line 50: if (network.isSetName()) {
Line 51: networkId = getNetworkId(network.getName(), clusterId);
not sure why clusterId is relevant here as in this stage we attach network to
cluster,
if it's works okay, +2
Line 52: if (networkId == null) {
Line 53: notFound(Network.class);
Line 54: }
Line 55: }
--
To view, visit http://gerrit.ovirt.org/14685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5fac9af37fec642fd3c0c6fbdb43ee04b364f2c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
