Michael Pasternak has posted comments on this change.
Change subject: restapi: Attaching network to cluster failure
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java
Line 34:
Line 35: @Override
Line 36: public Response add(Network network) {
Line 37: validateParameters(network, "name"); //right now, name is
mandatory (future - id alone will be enough)
Line 38: String networkId = getNetworkId(network.getName(), clusterId);
what if some will pass network-id only? - you'll always fail with 404,
you should enter in to this flow only if network-name is provided
Line 39: if (networkId == null) {
Line 40: notFound(Network.class);
Line 41: }
Line 42:
--
To view, visit http://gerrit.ovirt.org/14680
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43074bc0819b19873e11ac0203cd518459e6644
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
