Tomas Jelinek has uploaded a new change for review.
Change subject: userportal,webadmin: redesign of vm related dialogs
......................................................................
userportal,webadmin: redesign of vm related dialogs
- Added a header to DialogTabPanel which is always visible (if set)
- Added borders around the header and right side of the tab bar
- Removed some paddings
This redesign has some minor impact also on other dialogs (e.g. adding border
to the right side of the buttons tab). This is intentional to not have
different UX on different dialogs.
Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9
Signed-off-by: Tomas Jelinek <tjeli...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
3 files changed, 37 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/14635/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
index 351bee6..f415f48 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
@@ -1,6 +1,7 @@
package org.ovirt.engine.ui.common.widget.dialog.tab;
import com.google.gwt.core.client.GWT;
+import com.google.gwt.dom.client.Style.Display;
import com.google.gwt.event.dom.client.ClickEvent;
import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.KeyUpEvent;
@@ -21,6 +22,9 @@
}
@UiField
+ SimplePanel tabHeaderContainer;
+
+ @UiField
FlowPanel tabContainer;
@UiField
@@ -36,6 +40,12 @@
getWidget().setHeight(height);
}
+ @UiChild(tagname = "header", limit = 1)
+ public void setHeader(Widget widget) {
+ tabHeaderContainer.getElement().getStyle().setDisplay(Display.BLOCK);
+ tabHeaderContainer.add(widget);
+ }
+
@UiChild(tagname = "tab")
public void addTab(final DialogTab tab) {
tabContainer.add(tab);
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
index 20b0c2c..c11962b 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
@@ -8,17 +8,30 @@
width: 160px;
height: 100%;
background-color: #E5E5E5;
+ border-right: 1px solid #CED8DF;
}
.content {
+ }
+
+ .contentContainer {
overflow: hidden;
- padding-left: 5px;
+ }
+
+ .header {
+ background-color: #D3D3D3;
+ border-bottom: 1px solid #CED8DF;
+ margin-bottom: 15px;
+ display: none;
}
</ui:style>
<g:HTMLPanel>
<g:FlowPanel ui:field="tabContainer"
addStyleNames="{style.bar}" />
- <g:SimplePanel ui:field="tabContentContainer"
addStyleNames="{style.content}" />
+ <g:FlowPanel addStyleNames="{style.contentContainer}">
+ <g:SimplePanel ui:field="tabHeaderContainer"
addStyleNames="{style.header}" />
+ <g:SimplePanel ui:field="tabContentContainer"
addStyleNames="{style.content}" />
+ </g:FlowPanel>
<div style="clear: both;" />
</g:HTMLPanel>
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
index 264cb2d..38dcdc7 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
@@ -10,14 +10,6 @@
<ui:with field='constants'
type='org.ovirt.engine.ui.common.CommonApplicationConstants'/>
<ui:style
type="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget.Style">
- .generalTabTopDecorator {
- background-color: #D3D3D3;
- margin-top: 4px;
- margin-right: 3px;
- margin-bottom: 20px;
- padding-top: 6px;
- padding-bottom: 6px;
- }
.sectionPanel {
margin-bottom: 20px;
@@ -208,18 +200,25 @@
width: 250px !important;
}
+ .headerPanel {
+ margin-right: 3px;
+ padding-top: 6px;
+ padding-bottom: 6px;
+ }
</ui:style>
<t:DialogTabPanel width="100%" height="100%">
+ <t:header>
+ <g:FlowPanel addStyleNames="{style.headerPanel}">
+ <e:ListModelListBoxEditor
ui:field="dataCenterEditor" />
+ <e:ListModelListBoxEditor
ui:field="clusterEditor" />
+ <e:ListModelListBoxEditor
ui:field="quotaEditor" />
+ </g:FlowPanel>
+ </t:header>
<t:tab>
<t:DialogTab ui:field="generalTab">
<t:content>
<g:FlowPanel>
- <g:FlowPanel
addStyleNames="{style.generalTabTopDecorator}">
-
<e:ListModelListBoxEditor ui:field="dataCenterEditor" />
-
<e:ListModelListBoxEditor ui:field="clusterEditor" />
-
<e:ListModelListBoxEditor ui:field="quotaEditor" />
- </g:FlowPanel>
<g:FlowPanel
addStyleNames="{style.sectionPanel}">
<g:FlowPanel
addStyleNames="{style.name}">
<g:FlowPanel
addStyleNames="{style.prestartedLabelWithHelp}">
--
To view, visit http://gerrit.ovirt.org/14635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
