Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactoring AddVdsCommand#canDoAction() ......................................................................
engine: Refactoring AddVdsCommand#canDoAction() to use failCanDoAction(), saving few lines of code. Also made sure that the gluster specific validation happens only if all previous validation was successful. Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602 Signed-off-by: Shireesh Anjal <anjalshire...@gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 10 insertions(+), 17 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2525aa9ce72654fea18eb60948a87d95a636602 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches