Michael Pasternak has posted comments on this change.

Change subject: core, restapi: Don't store domain suffix in user name
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
Commit Message
Line 25: 
Line 26: Note that both in the RESTAPI and in the GUI the domain name will 
appear
Line 27: with the same case that it has in the database, which is lower case by
Line 28: default. This is different than it used to be, as it used to be upper
Line 29: case. Is this relevant?
can't think of something in api as domain backlinked from the user resource.
Line 30: 
Line 31: Change-Id: Iaa6788600e0a68696f1d358a99223ecc1c75382c


--
To view, visit http://gerrit.ovirt.org/14255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6788600e0a68696f1d358a99223ecc1c75382c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to