Arik Hadas has posted comments on this change. Change subject: webadmin: Correct timezone default in New/Edit VM dialog ......................................................................
Patch Set 2: I would prefer that you didn't submit this Martin, you dropped the empty entry without introducing any solution to the bug it solved. I verified that this patch makes bug 922609 to reproduce. I didn't like the empty entry solution in that time either but that's the best solution we found back then. Roy suggested a better solution - to add an update script that convert null or empty timezones to the default timezone (and maybe to change the time zone entry in the DB to be not NULL). this bug must not be merged without verifying that bug 922609 is not occurring again. -- To view, visit http://gerrit.ovirt.org/14248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaccb31f5634c16583004a79b9b47b83ff994088a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbe...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Beták <mbe...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
