Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Boxed value is unboxed and then immediately reboxed ......................................................................
findbugs: Boxed value is unboxed and then immediately reboxed Change-Id: I28465ef80d706a5e8c08b3e3a92bd00f4a7de94f Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/14581/1 diff --git a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java index 9e2b786..427f985 100644 --- a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java +++ b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java @@ -62,9 +62,9 @@ vds.setCpuSpeedMh(5.5); Host host = HostMapper.map(vds, (Host) null); assertNotNull(host.getCpu()); - assertEquals(Integer.valueOf(host.getCpu().getTopology().getCores()), Integer.valueOf(2)); - assertEquals(Integer.valueOf(host.getCpu().getTopology().getSockets()), Integer.valueOf(3)); - assertEquals(Integer.valueOf(host.getCpu().getTopology().getThreads()), Integer.valueOf(2)); + assertEquals(host.getCpu().getTopology().getCores().intValue(), 2); + assertEquals(host.getCpu().getTopology().getSockets().intValue(), 3); + assertEquals(host.getCpu().getTopology().getThreads().intValue(), 2); assertEquals(host.getCpu().getName(), "some cpu model"); assertEquals(host.getCpu().getSpeed(), new BigDecimal(5.5)); } @@ -89,7 +89,7 @@ vds.setPhysicalMemMb(4000); Host host = HostMapper.map(vds, (Host) null); assertNotNull(host.getMemory()); - assertEquals(Long.valueOf(host.getMemory()), Long.valueOf(4194304000L)); + assertEquals(host.getMemory().longValue(), 4194304000L); } @Test -- To view, visit http://gerrit.ovirt.org/14581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28465ef80d706a5e8c08b3e3a92bd00f4a7de94f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
