Alissa Bonas has posted comments on this change.
Change subject: core: setStorage once in AddSanStorageDomainCommand
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java
Line 40: // set domain storage to empty because not nullable in db and
for shared
Line 41: // status to be locked
Line 42: getStorageDomain().setStorage("");
Line 43: addStorageDomainInDb();
Line 44: if(StringUtils.isEmpty(storage)) {
the "storage" variable isn't used before, however it is assigned to
getStorageDomain.getStorage() before it's overriden by "" in line 40. I have to
say the entire assignment to "", saving to db and then overriding it with
something else doesn't make much sense to me, but I prefer not to touch it too
much without proper understanding.
Line 45: storage = createVG();
Line 46: }
Line 47: getStorageDomain().setStorage(storage);
Line 48: if (StringUtils.isNotEmpty(getStorageDomain().getStorage()) &&
(addStorageDomainInIrs())) {
--
To view, visit http://gerrit.ovirt.org/14518
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc63f032f274437e0ffbc14392b19e9239fcb8c0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
