Shireesh Anjal has posted comments on this change. Change subject: engine: adding gluster_server table and dao operations ......................................................................
Patch Set 9: Looks good to me, but someone else must approve (2 inline comments) Couple of minor comments in-line. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerDao.java Line 12: public GlusterServer getByServerId(Guid serverId); Line 13: Line 14: public GlusterServer getByGlusterServerUuid(Guid glusterServerUuid); Line 15: Line 16: public void remove(Guid serverId); This method already exists in parent interface ModificationDao#remove(), so need not be added again here. Line 17: Line 18: public void removeByGlusterServerUuid(Guid glusterServerUuid); Line 19: Line 20: public void update(GlusterServer vdsGluster); Line 16: public void remove(Guid serverId); Line 17: Line 18: public void removeByGlusterServerUuid(Guid glusterServerUuid); Line 19: Line 20: public void update(GlusterServer vdsGluster); Same here. -- To view, visit http://gerrit.ovirt.org/14063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04ba0a7bf1eaa964db731cdfa24ab6875e0b1513 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
