Allon Mureinik has posted comments on this change.
Change subject: core: ReplicateDisk - prevent rollback on engine restart
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
Line 163: // (checks whether the disk moved successfully to the target
storage domain)
Line 164: Guid targetStorageDomainId =
getEnclosingCommand().getParameters().getTargetStorageDomainId();
Line 165: Guid destinationImageId =
getEnclosingCommand().getParameters().getDestinationImageId();
Line 166: DiskImage diskImage =
getDiskImageDao().get(destinationImageId);
Line 167: if (diskImage != null && diskImage.getStorageIds().get(0) ==
targetStorageDomainId) {
Use equals - there is no guarantee that it's the same Guid instance.
Line 168:
getEnclosingCommand().getParameters().setExecutionIndex(0);
Line 169: }
Line 170: }
Line 171:
--
To view, visit http://gerrit.ovirt.org/14441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
