Yair Zaslavsky has posted comments on this change.
Change subject: Modify error to info report after fencing and fixing print
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 633: }
Line 634: setStatus(VDSStatus.NonResponsive, vds);
Line 635: log.infoFormat(
Line 636: "Server failed to respond, vds_id = {0}, vds_name
= {1}, vm_count = {2}, " +
Line 637: "spm_status = {3}, non-responsive_timeout = {4},
error = {5}",
Please add the proper time unit here at the log print, otherwise it will not be
clear.
Line 638: vds.getId(), vds.getName(), vds.getVmCount(),
vds.getSpmStatus(),
Line 639: TimeUnit.MILLISECONDS.toSeconds(timeoutToFence),
ex.getMessage());
Line 640:
Line 641: AuditLogableBase logable = new
AuditLogableBase(vds.getId());
--
To view, visit http://gerrit.ovirt.org/14495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9411c286b20f6e0627d5699ca8ea294e443cf6ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
