Greg Padgett has posted comments on this change. Change subject: engine: hashcode method simplification ......................................................................
Patch Set 1: Looks good to me, but someone else must approve I really like it! Makes the hashCode() method look much cleaner and easier to maintain. Just one nit: what about changing HashCodeBuilder.result() to HashCodeBuilder.toHashCode()? Then your API would match that of the Apache Commons HashCodeBuilder. -- To view, visit http://gerrit.ovirt.org/14386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15afc6227f2a4d67befbdfe67b8c42b381308228 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
