Michael Pasternak has posted comments on this change. Change subject: cli: 'list' command does not work as expected ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File src/ovirtcli/command/list.py Line 148: opts = self.options Line 149: typs = self.get_plural_types(method='list', typ=args[0]) Line 150: Line 151: if len(args) > 1: Line 152: self.error(Messages.Error.INVALID_ARGUMENT_SEGMENT % str(args[1:])) INVALID_ARGUMENT_SEGMENT is not a right error in this case, also it should be treated at string compilation phase, please make sure command fails with 'bad syntax' Line 153: Line 154: self.context.formatter.format(self.context, Line 155: self.get_collection(typ=args[0], Line 156: opts=opts, -- To view, visit http://gerrit.ovirt.org/14009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie63b9ecad913dc25dd4acbc6a3bc7174651f87c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
