[Engine-patches] Change in ovirt-engine[master]: findbugs: switch case missing break

[shavivi]

Shahar Havivi has uploaded a new change for review.

Change subject: findbugs: switch case missing break
......................................................................

findbugs: switch case missing break

Change-Id: I74a856015d74025399ff774d91e250b5cbd53184
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M 
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
M 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VersionHelper.java
M 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
4 files changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/14380/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
index edeee1b..c057e18 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
@@ -189,6 +189,7 @@
             getSnapshotDao().updateStatus(
                     getSnapshotDao().getId(getVmId(), SnapshotType.REGULAR, 
SnapshotStatus.IN_PREVIEW),
                     SnapshotStatus.OK);
+            break;
         case STATELESS:
             restoreConfiguration(targetSnapshot);
             break;
diff --git 
a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
 
b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
index 5a91e70..101952c 100644
--- 
a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
+++ 
b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java
@@ -81,12 +81,16 @@
             switch (partialVersions.length) {
             case (4):
                 revision = Integer.parseInt(partialVersions[3]);
+                break;
             case (3):
                 build = Integer.parseInt(partialVersions[2]);
+                break;
             case (2):
                 minor = Integer.parseInt(partialVersions[1]);
+                break;
             case (1):
                 major = Integer.parseInt(partialVersions[0]);
+                break;
             }
         }
     }
@@ -96,12 +100,16 @@
         switch (i) {
         case (4):
             sb.append(".").append(revision);
+            break;
         case (3):
             sb.insert(0, build).insert(0, ".");
+            break;
         case (2):
             sb.insert(0, minor).insert(0, ".");
+            break;
         case (1):
             sb.insert(0, major);
+            break;
         }
         return sb.toString();
     }
diff --git 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VersionHelper.java
 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VersionHelper.java
index 9c1fe71..f6b5798 100644
--- 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VersionHelper.java
+++ 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VersionHelper.java
@@ -15,12 +15,16 @@
         switch (parts.length) {
         case 4:
             version.setRevision(Integer.parseInt(parts[3]));
+            break;
         case 3:
             version.setBuild(Integer.parseInt(parts[2]));
+            break;
         case 2:
             version.setMinor(Integer.parseInt(parts[1]));
+            break;
         case 1:
             version.setMajor(Integer.parseInt(parts[0]));
+            break;
         }
         return version;
     }
diff --git 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
index b4f53ae..1393389 100644
--- 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
+++ 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
@@ -162,6 +162,7 @@
                 switch (entity.getselection_algorithm()) {
                 case PowerSave:
                     model.getThresholds().setLow(entity.getlow_utilization());
+                    break;
                 case EvenlyDistribute:
                     
model.getThresholds().setHigh(entity.gethigh_utilization());
                     
model.getThresholds().setDuration(entity.getcpu_over_commit_duration_minutes() 
* 60);


--
To view, visit http://gerrit.ovirt.org/14380
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74a856015d74025399ff774d91e250b5cbd53184
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches