Yair Zaslavsky has posted comments on this change. Change subject: core: config: support sensitive keys ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java Line 120: // problem to use INFO): Line 121: if (log.isInfoEnabled()) { Line 122: Set<String> keys = values.keySet(); Line 123: List<String> list = new ArrayList<String>(keys.size()); Line 124: List<String> sensitiveKeys = Arrays.asList(getSensitiveKeys()); Please use Set. Line 125: list.addAll(keys); Line 126: Collections.sort(list); Line 127: for (String key : list) { Line 128: String value = "***"; -- To view, visit http://gerrit.ovirt.org/14353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc10fb3eeb1cc97a03cc160133a84d6b2a23d87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches