Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Auto update quota by template
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

fix minor comment while rebasing.

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
Line 189:         UpdateDefaultHost();
Line 190:         updateCustomPropertySheet();
Line 191:         UpdateMinAllocatedMemory();
Line 192:         UpdateNumOfSockets();
Line 193:         if ((VmTemplate) getModel().getTemplate().getSelectedItem() 
!= null) {
redundant cast
Line 194:             VmTemplate template = (VmTemplate) 
getModel().getTemplate().getSelectedItem();
Line 195:             updateQuotaByCluster(template.getQuotaId(), 
template.getQuotaName());
Line 196:         }
Line 197:         updateCpuPinningVisibility();


--
To view, visit http://gerrit.ovirt.org/14112
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1d70b895738218e551128c73415a1cbd33e8915
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to