Daniel Erez has uploaded a new change for review.
Change subject: webadmin: ISO/Export sub-tabs resizable columns
......................................................................
webadmin: ISO/Export sub-tabs resizable columns
ISO/Export sub-tabs under Storage main-tab
now support resizable columns.
* Invoked enableColumnResizing() on each sub-tab.
* Added a static width value for each column.
Change-Id: Icf75b725fe9efa63c3e0a949c9d1bb9f6590d1aa
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
3 files changed, 22 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/14279/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
index 7fdd603..fa02eb2 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
@@ -25,13 +25,15 @@
}
void initTable(ApplicationResources resources, final ApplicationConstants
constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<EntityModel> fileNameColumn = new
TextColumnWithTooltip<EntityModel>() {
@Override
public String getValue(EntityModel object) {
return object.getTitle();
}
};
- getTable().addColumn(fileNameColumn, constants.fileNameIso());
+ getTable().addColumn(fileNameColumn, constants.fileNameIso(),
"500px"); //$NON-NLS-1$
TextColumnWithTooltip<EntityModel> typeColumn = new
TextColumnWithTooltip<EntityModel>() {
@Override
@@ -39,7 +41,7 @@
return object.getEntity().toString();
}
};
- getTable().addColumn(typeColumn, constants.typeIso());
+ getTable().addColumn(typeColumn, constants.typeIso(), "200px");
//$NON-NLS-1$
getTable().showRefreshButton();
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
index a919abf..1835e46 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java
@@ -32,6 +32,8 @@
}
void initTable(final ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
TextColumnWithTooltip<VmTemplate> nameColumn =
new TextColumnWithTooltip<VmTemplate>() {
@Override
@@ -39,7 +41,7 @@
return object.getName();
}
};
- getTable().addColumn(nameColumn, constants.nameTemplate());
+ getTable().addColumn(nameColumn, constants.nameTemplate(), "160px");
//$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> originColumn =
new TextColumnWithTooltip<VmTemplate>() {
@@ -49,7 +51,7 @@
.toString();
}
};
- getTable().addColumn(originColumn, constants.originTemplate());
+ getTable().addColumn(originColumn, constants.originTemplate(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> memoryColumn =
new TextColumnWithTooltip<VmTemplate>() {
@@ -58,7 +60,7 @@
return String.valueOf(object.getMemSizeMb()) + " MB";
//$NON-NLS-1$
}
};
- getTable().addColumn(memoryColumn,constants.memoryTemplate());
+ getTable().addColumn(memoryColumn, constants.memoryTemplate(),
"160px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> cpuColumn =
new TextColumnWithTooltip<VmTemplate>() {
@@ -67,7 +69,7 @@
return String.valueOf(object.getNumOfCpus());
}
};
- getTable().addColumn(cpuColumn, constants.cpusVm());
+ getTable().addColumn(cpuColumn, constants.cpusVm(), "160px");
//$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> diskColumn =
new TextColumnWithTooltip<VmTemplate>() {
@@ -76,7 +78,7 @@
return String.valueOf(object.getDiskList().size());
}
};
- getTable().addColumn(diskColumn, constants.disksTemplate());
+ getTable().addColumn(diskColumn, constants.disksTemplate(), "160px");
//$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> creationDateColumn =
new GeneralDateTimeColumn<VmTemplate>() {
@@ -85,7 +87,7 @@
return object.getCreationDate();
}
};
- getTable().addColumn(creationDateColumn,
constants.creationDateTemplate());
+ getTable().addColumn(creationDateColumn,
constants.creationDateTemplate(), "160px"); //$NON-NLS-1$
TextColumnWithTooltip<VmTemplate> exportDateColumn =
new GeneralDateTimeColumn<VmTemplate>() {
@@ -94,7 +96,7 @@
return object.getExportDate();
}
};
- getTable().addColumn(exportDateColumn, constants.exportDateTemplate());
+ getTable().addColumn(exportDateColumn, constants.exportDateTemplate(),
"160px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<VmTemplate>(constants.restoreVm()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
index 5318102..e3af215 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
@@ -69,6 +69,7 @@
}
void initVmTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
getTable().addColumn(new VmStatusColumn(), constants.empty(), "30px");
//$NON-NLS-1$
@@ -78,7 +79,7 @@
return object.getName();
}
};
- getTable().addColumn(nameColumn, constants.nameVm());
+ getTable().addColumn(nameColumn, constants.nameVm(), "95px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> templateColumn = new
TextColumnWithTooltip<VM>() {
@Override
@@ -86,7 +87,7 @@
return object.getVmtName();
}
};
- getTable().addColumn(templateColumn, constants.templateVm());
+ getTable().addColumn(templateColumn, constants.templateVm(), "95px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> originColumn = new EnumColumn<VM,
OriginType>() {
@Override
@@ -94,7 +95,7 @@
return object.getOrigin();
}
};
- getTable().addColumn(originColumn, constants.originVm());
+ getTable().addColumn(originColumn, constants.originVm(), "95px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> memoryColumn = new
TextColumnWithTooltip<VM>() {
@Override
@@ -102,7 +103,7 @@
return String.valueOf(object.getVmMemSizeMb()) + " MB";
//$NON-NLS-1$
}
};
- getTable().addColumn(memoryColumn, constants.memoryVm());
+ getTable().addColumn(memoryColumn, constants.memoryVm(), "95px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> cpuColumn = new TextColumnWithTooltip<VM>() {
@Override
@@ -110,7 +111,7 @@
return String.valueOf(object.getNumOfCpus());
}
};
- getTable().addColumn(cpuColumn, constants.cpusVm());
+ getTable().addColumn(cpuColumn, constants.cpusVm(), "95px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> diskColumn = new TextColumnWithTooltip<VM>()
{
@Override
@@ -118,7 +119,7 @@
return String.valueOf(object.getDiskMap().size());
}
};
- getTable().addColumn(diskColumn, constants.disksVm());
+ getTable().addColumn(diskColumn, constants.disksVm(), "95px");
//$NON-NLS-1$
TextColumnWithTooltip<VM> creationDateColumn = new
GeneralDateTimeColumn<VM>() {
@Override
@@ -126,7 +127,7 @@
return object.getVmCreationDate();
}
};
- getTable().addColumn(creationDateColumn, constants.creationDateVm());
+ getTable().addColumn(creationDateColumn, constants.creationDateVm(),
"95px"); //$NON-NLS-1$
TextColumnWithTooltip<VM> exportDateColumn = new
GeneralDateTimeColumn<VM>() {
@Override
@@ -134,7 +135,7 @@
return object.getExportDate();
}
};
- getTable().addColumn(exportDateColumn, constants.exportDateVm());
+ getTable().addColumn(exportDateColumn, constants.exportDateVm(),
"95px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<VM>(constants.restoreVm()) {
@Override
--
To view, visit http://gerrit.ovirt.org/14279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf75b725fe9efa63c3e0a949c9d1bb9f6590d1aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
