Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: quota - subtabs resizable columns
......................................................................
webadmin: quota - subtabs resizable columns
Invoking enableColumnResizing() in all quota related subtabs,
and set fixed width for the sub-tab columns.
Quota subtab under datacenters main tab was already
covered in another patch.
Change-Id: Ib4702514c4316a4e2022018d6439e437d326caac
Signed-off-by: Gilad Chaplik <gchap...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserQuotaView.java
4 files changed, 20 insertions(+), 34 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/14278/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
index 079d9f3..2f07b4a 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
@@ -33,6 +33,8 @@
}
private void initTable(final ApplicationConstants constants, final
ApplicationMessages messages) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new TextColumnWithTooltip<QuotaVdsGroup>() {
@Override
public String getValue(QuotaVdsGroup object) {
@@ -40,7 +42,8 @@
: object.getVdsGroupName();
}
},
- constants.nameCluster());
+ constants.nameCluster(),
+ "300px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<QuotaVdsGroup>() {
@Override
@@ -54,7 +57,7 @@
}
}
},
- constants.usedMemoryTotalCluster());
+ constants.usedMemoryTotalCluster(), "300px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<QuotaVdsGroup>() {
@Override
@@ -68,7 +71,7 @@
}
}
},
- constants.runningCpuTotalCluster());
+ constants.runningCpuTotalCluster(), "300px"); //$NON-NLS-1$
}
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
index 72d2fec..3a15dc7 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java
@@ -39,6 +39,8 @@
}
private void initTable(final ApplicationConstants constants, final
ApplicationMessages messages) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new TextColumnWithTooltip<QuotaStorage>() {
@Override
public String getValue(QuotaStorage object) {
@@ -46,7 +48,8 @@
: object.getStorageName();
}
},
- constants.nameQuotaStorage());
+ constants.nameQuotaStorage(),
+ "400px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithEditableTooltip<QuotaStorage>()
{
@Override
@@ -72,6 +75,6 @@
return textCellWithEditableTooltip;
}
},
- constants.usedStorageTotalQuotaStorage());
+ constants.usedStorageTotalQuotaStorage(), "400px");
//$NON-NLS-1$
}
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java
index 3a5abcc..3a329f4 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java
@@ -35,6 +35,8 @@
}
private void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new PermissionTypeColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
TextColumnWithTooltip<permissions> userColumn = new
TextColumnWithTooltip<permissions>() {
@@ -43,7 +45,7 @@
return object.getOwnerName();
}
};
- getTable().addColumn(userColumn, constants.userUser());
+ getTable().addColumn(userColumn, constants.userUser(), "400px");
//$NON-NLS-1$
TextColumnWithTooltip<permissions> permissionColumn = new
ObjectNameColumn<permissions>() {
@Override
@@ -53,7 +55,7 @@
};
}
};
- getTable().addColumn(permissionColumn, constants.inheritedFromUser());
+ getTable().addColumn(permissionColumn, constants.inheritedFromUser(),
"400px"); //$NON-NLS-1$
getTable().addActionButton(new
WebAdminButtonDefinition<permissions>(constants.addUser()) {
@Override
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserQuotaView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserQuotaView.java
index fd656b4..2103fd6 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserQuotaView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserQuotaView.java
@@ -24,6 +24,8 @@
}
void initTable(ApplicationConstants constants) {
+ getTable().enableColumnResizing();
+
getTable().addColumn(new QuotaDcStatusColumn(), constants.empty(),
"30px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@@ -31,44 +33,20 @@
public String getValue(Quota object) {
return object.getQuotaName() == null ? "" :
object.getQuotaName(); //$NON-NLS-1$
}
- }, constants.nameQuota());
+ }, constants.nameQuota(), "300px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@Override
public String getValue(Quota object) {
return object.getDescription() == null ? "" :
object.getDescription(); //$NON-NLS-1$
}
- }, constants.descriptionQuota());
+ }, constants.descriptionQuota(), "300px"); //$NON-NLS-1$
getTable().addColumn(new TextColumnWithTooltip<Quota>() {
@Override
public String getValue(Quota object) {
return object.getStoragePoolName() == null ? "" :
object.getStoragePoolName(); //$NON-NLS-1$
}
- }, constants.dcQuota());
-// getTable().addColumn(new TextColumnWithTooltip<Quota>() {
-// @Override
-// public String getValue(Quota object) {
-// return (object.getMemSizeMBUsage() == null ? "0" :
object.getMemSizeMBUsage().toString()) + "/" //$NON-NLS-1$ //$NON-NLS-2$
-// + (object.getMemSizeMB() == null ? "*" :
object.getMemSizeMB().toString()) + " GB"; //$NON-NLS-1$ //$NON-NLS-2$
-// }
-// },
-// constants.usedMemoryQuota());
-// getTable().addColumn(new TextColumnWithTooltip<Quota>() {
-// @Override
-// public String getValue(Quota object) {
-// return (object.getVirtualCpuUsage() == null ? "0" :
object.getVirtualCpuUsage().toString()) + "/" //$NON-NLS-1$ //$NON-NLS-2$
-// + (object.getVirtualCpu() == null ? "*" :
object.getVirtualCpu().toString()); //$NON-NLS-1$
-// }
-// },
-// constants.runningCpuQuota());
-// getTable().addColumn(new TextColumnWithTooltip<Quota>() {
-// @Override
-// public String getValue(Quota object) {
-// return (object.getStorageSizeGBUsage() == null ? "0" :
object.getStorageSizeGBUsage().toString()) + "/" //$NON-NLS-1$ //$NON-NLS-2$
-// + (object.getStorageSizeGB() == null ? "*" :
object.getStorageSizeGB().toString()) + " GB"; //$NON-NLS-1$ //$NON-NLS-2$
-// }
-// },
-// constants.usedStorageQuota());
+ }, constants.dcQuota(), "300px"); //$NON-NLS-1$
}
}
--
To view, visit http://gerrit.ovirt.org/14278
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4702514c4316a4e2022018d6439e437d326caac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
