Daniel Erez has posted comments on this change. Change subject: core: Introducing the comparators package ......................................................................
Patch Set 2: (3 inline comments) .................................................... File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml Line 122: <include name="common/businessentities/VmExitStatus.java" /> Line 123: <include name="common/businessentities/VmOsType.java" /> Line 124: <include name="common/businessentities/OsType.java" /> Line 125: <include name="common/businessentities/VmPoolType.java" /> Line 126: <include name="common/businessentities/comparators/VmsComparer.java" /> can be removed from this file (not used by the UI) Line 127: <include name="common/businessentities/comparators/VmsComparerByDiskSize.java" /> Line 128: <include name="common/businessentities/VmStatic.java" /> Line 129: <include name="common/businessentities/VmStatistics.java" /> Line 130: <include name="common/businessentities/VMStatus.java" /> Line 123: <include name="common/businessentities/VmOsType.java" /> Line 124: <include name="common/businessentities/OsType.java" /> Line 125: <include name="common/businessentities/VmPoolType.java" /> Line 126: <include name="common/businessentities/comparators/VmsComparer.java" /> Line 127: <include name="common/businessentities/comparators/VmsComparerByDiskSize.java" /> same Line 128: <include name="common/businessentities/VmStatic.java" /> Line 129: <include name="common/businessentities/VmStatistics.java" /> Line 130: <include name="common/businessentities/VMStatus.java" /> Line 131: <include name="common/businessentities/VmTemplate.java" /> Line 180: <include name="common/AuditLogType.java" /> Line 181: <include name="common/AuditLogTimeInterval.java" /> Line 182: <include name="common/AuditLogSeverity.java" /> Line 183: <include name="common/users/VdcUser.java" /> Line 184: <include name="common/utils/EnumUtils.java" /> should be moved to 'comparators' package as well? Line 185: <include name="common/utils/LexoNumericComparator.java" /> Line 186: <include name="common/utils/ListUtils.java" /> Line 187: <include name="common/utils/StringUtil.java"/> Line 188: <include name="common/utils/ObjectUtils.java" /> -- To view, visit http://gerrit.ovirt.org/14192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70f2432df8338c736d9ab0e6c97e38acf3ddf92f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
