Allon Mureinik has posted comments on this change.
Change subject: engine: engine: add comment field to storage domain
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Sorry, missed the DB issue in my previous comment
....................................................
File backend/manager/dbscripts/upgrade/03_02_0520_add_comment_storage_domain.sql
Line 1: select fn_db_add_column('storage_domain_static', 'comment',
'VARCHAR(4000) NOT NULL default ''''');
why not null?
why use an empty string instead of a proper DB null?
--
To view, visit http://gerrit.ovirt.org/14131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id946f079406f6d1ec3951499276093f68b3b5250
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
