Allon Mureinik has posted comments on this change.
Change subject: engine: add comment field to storage pool
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 57: v_storage_pool_type INTEGER,
Line 58: v_storage_pool_format_type VARCHAR(50),
Line 59: v_compatibility_version VARCHAR(40),
Line 60: v_quota_enforcement_type INTEGER,
Line 61: v_comment VARCHAR(4000))
update_partial is an optimization for updating only minimal set of fields in
touchy situations.
Updating the comment is not one of them - please remove
Line 62: RETURNS VOID
Line 63:
Line 64: --The [storage_pool] table doesn't have a timestamp column.
Optimistic concurrency logic cannot be generated
Line 65: AS $procedure$
....................................................
File backend/manager/dbscripts/upgrade/03_02_0510_add_comment_storage_pool.sql
Line 1: select fn_db_add_column('storage_pool', 'comment', 'VARCHAR(4000) NOT
NULL default ''''');
why NOT NULL?
Why enforce an empty string instead of a proper null?
....................................................
Commit Message
Line 7: engine: add comment field to storage pool
Line 8:
Line 9: Part of the adding a comment field to many parts of the system
Line 10:
Line 11: - Add column in the data base
database is one word
Line 12: - change dao
Line 13: - add comment to storage_pool
Line 14: - add comment to Model & ModelList
Line 15: - reflect changes in the UI
Line 12: - change dao
Line 13: - add comment to storage_pool
Line 14: - add comment to Model & ModelList
Line 15: - reflect changes in the UI
Line 16:
No BZ url?
Line 17: Change-Id: I95658d96f4cce3408b35670a8c2abccef6ee6eb3
--
To view, visit http://gerrit.ovirt.org/13677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95658d96f4cce3408b35670a8c2abccef6ee6eb3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
