Allon Mureinik has posted comments on this change.
Change subject: engine: replace some parameter classes with IdQueryParameters
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
I really like where this patch is going, but I'm wondering why you didn't also
want to remove the following:
etAllDisksByVmIdParameters
GetAllVmSnapshotsByVmIdParameters
GetAuditLogByIdParameters
GetByUserIdParameters
GetDbUserByVmPoolIdParameters
GetEventSubscribersBySubscriberIdParameters
GetHostsByClusterIdParameters
GetLunsByVgIdParameters
GetPermittedStorageDomainsByStoragePoolIdParameters
GetStorageDomainsByImageIdParameters
GetTagByTagIdParameters
GetTagsByUserGroupIdParameters
GetTagsByUserIdParameters
GetTagsByVdsIdParameters
GetTagsByVmIdParameters
GetVdsByVdsIdParameters
GetVdsGroupByIdParameters
GetVdsGroupByVdsGroupIdParameters
GetVdsHooksByIdParameters
GetVmdataByPoolIdParameters
GetVmPoolByIdParameters
GetVmPoolByIdParametersBase
GetVmsByDiskGuidParameters
GetVmTemplatesByImageGuidParameters
GetVmTemplatesByStoragePoolIdParameters
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDbUserByUserIdQuery.java
Line 12: @Override
Line 13: protected void executeQueryCommand() {
Line 14: getQueryReturnValue().setReturnValue(
Line 15: DbFacade.getInstance().getDbUserDao()
Line 16: .get((getParameters()).getId()));
I wonder if there is any flow where user X can query user Y.
If not, this can be replaced with VdcQueryParametersBase, and just use
getUserId()
Line 17: }
--
To view, visit http://gerrit.ovirt.org/14260
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I057ce109ecde4d86312bd4e96803bf62229e1741
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
