Allon Mureinik has posted comments on this change.
Change subject: core: initVdsOnUp - remove reconstruct and host status.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
minor issues, see inline
....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 473: END; $procedure$
Line 474: LANGUAGE plpgsql;
Line 475:
Line 476:
Line 477: Create or replace FUNCTION
Getstorage_domain_by_type_for_storagePoolId(v_storage_domain_type INTEGER,
v_storage_pool_id UUID)
s/for/and/
Line 478: RETURNS SETOF storage_domains
Line 479: AS $procedure$
Line 480: BEGIN
Line 481: RETURN QUERY SELECT *
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 183: new
ConnectStoragePoolVDSCommandParameters(vds.getId(), storagePoolId,
Line 184: vds.getVdsSpmId(), masterDomain.getId(),
Line 185:
storagePool.getmaster_domain_version())).getSucceeded();
Line 186: } catch (VdcBLLException e) {
Line 187: boolean isMasterDomainInactiveOrUnknown =
(masterDomain.getStatus() == StorageDomainStatus.InActive
consider giving this boolean a name that describes its /meaining/, not what it
is - e.g., doesStatusProhibitConnect
Line 188: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown);
Line 189: if (e.getErrorCode() != VdcBllErrors.VDS_NETWORK_ERROR &&
isMasterDomainInactiveOrUnknown) {
Line 190: shouldProceedVdsStats = false;
Line 191: result.setSuccess(true);
--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6418b9d2826146e1e4ceff4341c6d7cd3a0024af
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
