Sahina Bose has posted comments on this change.
Change subject: gluster: Improved gluster validation in add host
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 381: try {
Line 382: sshclient = getSSHClient(vds.getHostName());
Line 383: sshclient.connect();
Line 384: sshclient.authenticate();
Line 385:
the ssh client disconnect will not be called if returned here
Line 386: return isValidGlusterPeer(sshclient);
Line 387: } catch (AuthenticationException e) {
Line 388: log.errorFormat(
Line 389: "Failed to authenticate session with host
{0}",
--
To view, visit http://gerrit.ovirt.org/14224
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06a2ee4621b175aa70f1ccdcf7a740d830494acf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
