[Engine-patches] Change in ovirt-engine[master]: core: ImagesHandler.CheckImageConfiguration format

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: ImagesHandler.CheckImageConfiguration format
......................................................................

core: ImagesHandler.CheckImageConfiguration format

Improved the formatting of ImagesHandler.CheckImageConfiguration in
order to make it easier to read:
1. Removed useless parentheses that don't add readability
2. Reformatted so each major condition (separated by ||) starts in its
   own new line.

Change-Id: I07e4622ce2b6a6f90d88f72e37cdca0df313399b
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/14190/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
index dea9807..7e53248 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
@@ -421,9 +421,9 @@
             DiskImageBase diskInfo, List<String> messages) {
         boolean result = true;
         if ((diskInfo.getVolumeType() == VolumeType.Preallocated && 
diskInfo.getVolumeFormat() == VolumeFormat.COW)
-                || ((storageDomain.getStorageType().isBlockDomain()) && 
(diskInfo
-                        .getVolumeType() == VolumeType.Sparse && 
diskInfo.getVolumeFormat() == VolumeFormat.RAW))
-                || (diskInfo.getVolumeFormat() == VolumeFormat.Unassigned || 
diskInfo.getVolumeType() == VolumeType.Unassigned)) {
+                || (storageDomain.getStorageType().isBlockDomain() && 
diskInfo.getVolumeType() == VolumeType.Sparse && diskInfo.getVolumeFormat() == 
VolumeFormat.RAW)
+                || diskInfo.getVolumeFormat() == VolumeFormat.Unassigned
+                || diskInfo.getVolumeType() == VolumeType.Unassigned) {
             // not supported
             result = false;
             
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_DISK_CONFIGURATION_NOT_SUPPORTED.toString());


--
To view, visit http://gerrit.ovirt.org/14190
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07e4622ce2b6a6f90d88f72e37cdca0df313399b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches