Sahina Bose has uploaded a new change for review.
Change subject: engine:Fixing findbug error in gluster hooks list
......................................................................
engine:Fixing findbug error in gluster hooks list
Fixed a findbug error in GlusterHooksListReturnForXmlRpc
where hooks variable was not initialized.
Change-Id: I882d70750e4a55934f81ef81c8b0bb1c97256d7b
Signed-off-by: Sahina Bose <sab...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/14187/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java
index 3c8b9e6..68184f5 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.core.vdsbroker.gluster;
+import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@@ -27,10 +28,11 @@
}
Object[] hooksArr = (Object[]) innerMap.get(HOOKS_LIST);
+ hooks = new ArrayList<GlusterHookEntity>();
if (hooksArr != null) {
for (Object hookMap : hooksArr) {
- this.hooks.add(getHook((Map<String, Object>)hookMap));
+ hooks.add(getHook((Map<String, Object>)hookMap));
}
}
}
--
To view, visit http://gerrit.ovirt.org/14187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I882d70750e4a55934f81ef81c8b0bb1c97256d7b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
