Arik Hadas has posted comments on this change.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 108: addSnapshotToDB(createdSnapshotId);
Line 109: createSnapshotsForDisks(getDisksList(), newActiveSnapshotId);
Line 110:
Line 111: if (getTaskIdList().isEmpty()) {
Line 112: getParameters().setTaskGroupSuccess(true);
no, didn't mean to change the flow in which it's being called. before this
patch it was being called if the VM was diskless, in that case it will still be
called. there is no other flow in which it is called because if the VM has
disks then after calling 'createSnapshotsForDisks' method there will be tasks
(otherwise an exception will be thrown at line 148). I made this change because
I'll add the image creation for the memory soon and in that case the task group
should be set to true only is the VM is diskless and no task for memory image
creation was created - so it's a preparation for that.
Line 113: incrementVmGeneration();
Line 114: }
Line 115: setSucceeded(true);
Line 116: }
Line 134: }
Line 135: }
Line 136:
Line 137: private void createSnapshotsForDisks(List<DiskImage> disks, Guid
vmSnapshotId) {
Line 138: for (DiskImage image : getDisksList()) {
no different - remove 'disks' parameter
Line 139:
Line 140: VdcReturnValueBase vdcReturnValue =
Backend.getInstance().runInternalAction(
Line 141: VdcActionType.CreateSnapshot,
Line 142: buildCreateSnapshotParameters(image,
vmSnapshotId),
--
To view, visit http://gerrit.ovirt.org/14179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie401b3aa60abba497237e02c77d8d3a77cef9a20
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
