Alexander Wels has posted comments on this change.
Change subject: webadmin: Element IDs in System Tree and Tags
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Just one minor comment.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tags/TagItemCell.java
Line 29: private final ApplicationResources resources;
Line 30: private final ApplicationTemplates templates;
Line 31:
Line 32: private TagItemTextCell(ApplicationResources resources,
ApplicationTemplates templates) {
Line 33: super(new AbstractCell<SafeHtml>("click", "mouseover",
"mouseout") { //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
You use 'click', 'mouseover', 'mouseout' in several locations in this file.
Would it make sense to make constants for those?
Line 34: @Override
Line 35: public void render(Context context, SafeHtml value,
SafeHtmlBuilder sb) {
Line 36: TagModel tagModel = (TagModel) context.getKey();
Line 37: tagModel.setIsAvailable(false);
--
To view, visit http://gerrit.ovirt.org/14165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4341a4c4e1740c075987e2a57c0844fa72b971e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
