Laszlo Hornyak has posted comments on this change. Change subject: [WIP] core: Introducing findbugs filter to bll module ......................................................................
Patch Set 3: (1 inline comment) some questions inline. .................................................... File backend/manager/modules/bll/exclude-filters.xml Line 8: <Match> Line 9: <Class name="org.ovirt.engine.core.bll.RunVmCommandBase" /> Line 10: <Method name="delay"/> Line 11: <Bug code="RV"/> Line 12: </Match> We will have to put all the nasty code here to be excluded from the report? How easy will that be to maintain? Doesn't that also mean that we will put it here rather than fixing it? -- To view, visit http://gerrit.ovirt.org/14110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26b9cafc1832022693a7386277972a7e48a53f0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
