Yair Zaslavsky has posted comments on this change. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) I suspect you did not Add CacheManager ? (or at least find -name "CacheManager*" yieled in no result for me) .................................................... Commit Message Line 5: CommitDate: 2013-04-22 12:16:27 +0300 Line 6: Line 7: engine: Introducing using of Infinispan cache at TimeoutBase Line 8: Line 9: The TimeoutBase was ysed for the following purpose: s/ysed/used Line 10: 1. The audit event which has expiration time was put to it internal cache Line 11: 2. If the same event was tried to put again and it is expired, it was writtent to DB Line 12: Line 13: Sound simple but a following implementation contains: Line 7: engine: Introducing using of Infinispan cache at TimeoutBase Line 8: Line 9: The TimeoutBase was ysed for the following purpose: Line 10: 1. The audit event which has expiration time was put to it internal cache Line 11: 2. If the same event was tried to put again and it is expired, it was writtent to DB s/writtent/written Line 12: Line 13: Sound simple but a following implementation contains: Line 14: 1. Memory leak - if we never tried to put event when it was already expired, internal cache Line 15: never will be cleared -- To view, visit http://gerrit.ovirt.org/14117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
