Alon Bar-Lev has posted comments on this change.
Change subject: core: rhevm-upgrade creates log/helping files...
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File backend/manager/dbscripts/dbcustomfunctions.sh
Line 32: if [ ! -d "${MD5DIR}" ]; then
Line 33: mkdir -p ${MD5DIR}
Line 34: fi
Line 35: # Setting log files dir
Line 36: LOGDIR="/var/log/ovirt-engine/db"
You mean that because developers need to keep these logs you force them to have
world writable at /var?
This is not good practice...
If it that important for you, set default logs to the location of the script,
or worse case at $HOME/ovirt-engine/log/db or something.
Line 37: LOGFILE="${LOGDIR}/${ME}.log"
Line 38: if [ ! -d "${LOGDIR}" ]; then
Line 39: mkdir -p ${LOGDIR}
Line 40: fi
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 266
Line 267
Line 268
Line 269
Line 270
If MD5DIR is to be kept it should be kept in production at
/var/lib/ovirt-engine/db/md5 or something, well, I expect a parameter for the
script for that location.
For development you can put it at script location/lib/db/md5 or something...
--
To view, visit http://gerrit.ovirt.org/14090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89c6d9267a7f739bc3584ab3a59888cece50fb7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
