Vered Volansky has posted comments on this change. Change subject: core: PerformImagesChecks no check for no disks ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 13: Move VM has this check explicitly defined in its canDoAction, and is Line 14: deprecated, regardless. Line 15: Line 16: After this change, there is no difference between PerformImagesChecks Line 17: and checkDiskImages, so the later (which was private) was removed, s/later/latter Line 18: and the code inlined into PerformImagesChecks. Line 19: Line 20: Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee -- To view, visit http://gerrit.ovirt.org/14113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
