Mike Kolesnik has posted comments on this change. Change subject: findbugs: When implementing compareTo implement Object.equals as well ......................................................................
Patch Set 4: Actually I don't think the eclipse auto-generator is good enough in this regard. You can see that most people are for using accessors: http://stackoverflow.com/questions/1568091/why-use-getters-and-setters This has merit especially when classes are not final, which means they can be extended and the accessors behaviour changed. For example, hibernate will extend the class with a proxy which will allow lazy loading of fields from the DB. This of course is only an example. -- To view, visit http://gerrit.ovirt.org/14039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
