Hello Ravi Nori,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/14094

to review the following change.

Change subject: cli: unclear error message when using unsupported 2 levels 
attribute(#949642)
......................................................................

cli: unclear error message when using unsupported 2 levels attribute(#949642)

unclear error message (error: type "%s" does not exist.) when
using unsupported 2 levels attribute.

when using unsupported 2 levels attribute (both are not supported)
the returned error is not user friendly

Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854
Bug-Url: https://bugzilla.redhat.com/949642
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/94/14094/1

diff --git a/src/ovirtcli/command/command.py b/src/ovirtcli/command/command.py
index 1a818c0..b6209aa 100644
--- a/src/ovirtcli/command/command.py
+++ b/src/ovirtcli/command/command.py
@@ -112,7 +112,7 @@
                             obj_params_set_cand = params_set_cand.factory()
                             root_obj_params_set_cand = obj_params_set_cand
                         else:
-                            self.error(Messages.Error.NO_SUCH_TYPE) % props[i]
+                            self.error(Messages.Error.NO_SUCH_TYPE % props[i])
 
                         if not val:
                             
self.error(Messages.Error.INVALID_COLLECTION_BASED_OPTION_SYNTAX % prop)


--
To view, visit http://gerrit.ovirt.org/14094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to