Laszlo Hornyak has posted comments on this change.

Change subject: engine: entity snapshot valiadation
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java
Line 137:     private void checkEntityForRollback(BusinessEntity<?> entity) {
Line 138:         if(entity == null) {
Line 139:             throw new IllegalArgumentException("Can not create 
snapshot from a null entity");
Line 140:         }
Line 141:         Class<? extends BusinessEntity> entityClazz = 
entity.getClass();
Done
Line 142:         
if(DbFacade.getInstance().getDaoForEntity((Class<BusinessEntity<Serializable>>)entityClazz)
 == null) {
Line 143:             throw new IllegalArgumentException("There is no rollback 
DAO registered for entity type "+entityClazz.getName());
Line 144:         }
Line 145:     }


--
To view, visit http://gerrit.ovirt.org/13694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf28a6d3dd389ab303d2d482e25b94dab4dbafdd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to