Allon Mureinik has posted comments on this change.

Change subject: findbugs: Method fail to close stream
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

Consider using the Java7 autocloable syntax.

Regardless - +1. Looks fine to me, but I'd prefer having another set of eyes.

--
To view, visit http://gerrit.ovirt.org/14037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bea678c1aaeeb6dfe92b16e380e4bc631e3d09c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to