Allon Mureinik has posted comments on this change.
Change subject: core: add repo_file_id to repo_file_meta_data
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File backend/manager/dbscripts/create_views.sql
Line 90: storage_domain_static.id as storage_domain_id,
Line 91: storage_domain_static.storage_domain_type as
storage_domain_type,
Line 92: storage_pool_iso_map.storage_pool_id as storage_pool_id,
Line 93: storage_pool_iso_map.status as storage_domain_status,
Line 94: repo_file_meta_data.repo_image_id as repo_image_id,
fair enough
Line 95: repo_file_meta_data.size as size,
Line 96: repo_file_meta_data.date_created as date_created,
Line 97: repo_file_meta_data.last_refreshed as last_refreshed,
Line 98: repo_file_meta_data.file_type as file_type,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 515: repo_md.setSize(0);
Line 516:
repo_md.setRepoDomainId(repoStorageDomainId);
Line 517: repo_md.setDateCreated(null);
Line 518: repo_md.setRepoImageId(isoFile);
Line 519: repo_md.setRepoImageName(null);
fair enough
Line 520: repo_md.setFileType(imageType);
Line 521:
repoFileMetaDataDao.addRepoFileMap(repo_md);
Line 522: }
Line 523: return true;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java
Line 116: entity.setLastRefreshed(rs.getLong("last_refreshed"));
Line 117:
entity.setFileType(ImageFileType.forValue(rs.getInt("file_type")));
Line 118: return entity;
Line 119: }
Line 120: }
Yup, I missed that. Thanks.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java
Line 207: assertSame(true, !listOfRepoFiles.isEmpty());
Line 208: assertSame(
Line 209: true,
Line 210: listOfRepoFiles.get(0).getRepoImageId()
Line 211: .equals(newRepoFileMap.getRepoImageId()));
assertEquals(listOfRepoFiles.get(0).getRepoImageId(),
newRepoFileMap.getRepoImageId());
Line 212: assertSame(true,
Line 213: listOfRepoFiles.get(0).getLastRefreshed() ==
newRepoFileMap
Line 214: .getLastRefreshed());
Line 215: assertSame(true,
--
To view, visit http://gerrit.ovirt.org/13958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2791fa22820fc021938709f4a921ab4d6213fab7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
