Michael Pasternak has posted comments on this change. Change subject: cli: Error type "brick" does not exist." on replace brick ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File src/ovirtcli/command/action.py Line 160: """Execute the action command.""" Line 161: args = self.arguments Line 162: opts = self.options Line 163: Line 164: if not (TypeHelper.isKnownType(args[0])) and ParseHelper.getXmlType(args[0]) == None: i'm not sure how this change can help solving this this issue? 'brick' is not a valid type indeed, you should be converting it to GlusterBrick instead Line 165: self.error(Messages.Error.NO_SUCH_TYPE % args[0]) Line 166: Line 167: scope = '%s:%s' % (ParseHelper.getXmlWrapperType(args[0]), args[2]) Line 168: actionable_types = TypeHelper.get_actionable_types(expendNestedTypes=True, groupOptions=True) -- To view, visit http://gerrit.ovirt.org/13935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
