Moti Asayag has posted comments on this change.
Change subject: core: Grammar fix in audit log message
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 456: NETWORK_UPDATE_VM_INTERFACE_FAILED=Failed to update Interface
${InterfaceName} (${InterfaceType}) for VM ${VmName}. (User: ${UserName})
Line 457: NETWORK_HOST_USING_WRONG_CLUSER_VLAN=${VdsName} is having wrong vlan
id: ${VlanIdHost}, expected vlan id: ${VlanIdCluster}
Line 458: NETWORK_HOST_MISSING_CLUSER_VLAN=${VdsName} is missing vlan id:
${VlanIdCluster} that is expected by the cluster
Line 459: INVALID_INTERFACE_FOR_MANAGEMENT_NETWORK_CONFIGURATION=Failed to
activate host ${VdsName}. Host ${VdsName} has an invalid interface
${InterfaceName} for the management network configuration.
Line 460: VLAN_ID_MISMATCH_FOR_MANAGEMENT_NETWORK_CONFIGURATION=Failed to
activate host ${VdsName}. Host ${VdsName} has an interface ${InterfaceName} for
the management network configuration with VLAN-ID (${VlanId}) rather than
data-center definition (${MgmtVlanId}).
I think that 'different from' will be more appropriate than 'rather than'.
'Rather than' suppose to suggest an alternative which isn't the case in this
message.
Line 461: SETUP_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK_CONFIGURATION=Failed to
activate host ${VdsName} due to management network configuration failure.
Line 462: PERSIST_NETWORK_FAILED_FOR_MANAGEMENT_NETWORK=Failed to activate host
${VdsName} due to failure in persisting the management network configuration.
Line 463: SYSTEM_DEACTIVATED_STORAGE_DOMAIN=Storage Domain ${StorageDomainName}
(Data Center ${StoragePoolName}) was deactivated by system because it's not
visible by any of the hosts.
Line 464: SYSTEM_DEACTIVATE_STORAGE_DOMAIN_FAILED=Failed to deactivate Storage
Domain ${StorageDomainName} (Data Center ${StoragePoolName}).
--
To view, visit http://gerrit.ovirt.org/14017
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dce69f18243b305b7dce88f4d480f94c98d15cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
