Shireesh Anjal has posted comments on this change.

Change subject: gluster: Refactor GetGlusterServersForImportQuery
......................................................................


Patch Set 3: (1 inline comment)

Thanks Omer, new patch-set to follow.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java
Line 29:     }
Line 30: 
Line 31:     @Override
Line 32:     protected void executeQueryCommand() {
Line 33:         getQueryReturnValue().setSucceeded(true);
Done
Line 34: 
Line 35:         // Check whether the given server is already part of the 
cluster
Line 36:         if 
(getVdsStaticDao().getByHostName(getParameters().getServerName()) != null
Line 37:                 || 
getVdsStaticDao().getAllWithIpAddress(getParameters().getServerName()).size() > 
0) {


--
To view, visit http://gerrit.ovirt.org/13977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4620c19997c10b202ef5dc5abdbeee9f245937d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to