Tomas Jelinek has posted comments on this change.
Change subject: webadmin: GUI support for setting the new
VmPool.maxAssignedVmsPerUser property
......................................................................
Patch Set 2: (5 inline comments)
Where do you actually set this property to VmPool entity to send it to the
server? I did not find it here nor on the engine patch. Did I miss some patch?
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
Line 236:
<e:EntityModelTextBoxOnlyEditor ui:field="prestartedVmsEditor"
addStyleNames="{style.prestartedVmsEditor}"
contentWidgetStyleName="{style.prestartedVmsEditorContent}" />
Line 237: </g:FlowPanel>
Line 238:
Line 239: <g:FlowPanel
ui:field="newPoolEditMaxAssignedVmsPerUserPanel"
addStyleNames="{style.poolEditVms}">
Line 240: <g:FlowPanel
addStyleNames="{style.maxAssignedVmsPerUserLabel}">
please remove this tab on rebase
Line 241:
<g:Label text="{constants.maxAssignedVmsPerUser}"
addStyleNames="{style.maxAssignedVmsPerUserLabel}" />
Line 242:
<d:InfoIcon ui:field="newPoolMaxAssignedVmsPerUserIcon"
addStyleNames="{style.maxAssignedVmsPerUserIcon}" />
Line 243:
</g:FlowPanel>
Line 244:
<e:EntityModelTextBoxOnlyEditor ui:field="maxAssignedVmsPerUserEditor"
addStyleNames="{style.maxAssignedVmsPerUserEditor}"
contentWidgetStyleName="{style.maxAssignedVmsPerUserEditorContent}" />
Line 242:
<d:InfoIcon ui:field="newPoolMaxAssignedVmsPerUserIcon"
addStyleNames="{style.maxAssignedVmsPerUserIcon}" />
Line 243:
</g:FlowPanel>
Line 244:
<e:EntityModelTextBoxOnlyEditor ui:field="maxAssignedVmsPerUserEditor"
addStyleNames="{style.maxAssignedVmsPerUserEditor}"
contentWidgetStyleName="{style.maxAssignedVmsPerUserEditorContent}" />
Line 245: </g:FlowPanel>
Line 246:
same
Line 247: <!-- Edit VM Pool -->
Line 248: <g:FlowPanel
addStyleNames="{style.poolEditVms}" ui:field="editPoolEditVmsPanel">
Line 249:
<g:FlowPanel addStyleNames="{style.prestartedLabelWithHelp}">
Line 250:
<g:Label ui:field="editPrestartedVmsLabel"
addStyleNames="{style.prestartedLabel}" />
Line 262:
<e:EntityModelTextBoxOnlyEditor ui:field="incraseNumOfVmsEditor"
addStyleNames="{style.editPrestartedVmsEditor}"
contentWidgetStyleName="{style.textBox}" />
Line 263:
<g:Label text="{constants.vms}" addStyleNames="{style.increaseVmsInPoolVms}" />
Line 264:
</g:FlowPanel>
Line 265: </g:FlowPanel>
Line 266:
...and also here :)
Line 267: <g:FlowPanel
ui:field="editPoolEditMaxAssignedVmsPerUserPanel"
addStyleNames="{style.poolEditVms}">
Line 268: <g:FlowPanel
addStyleNames="{style.maxAssignedVmsPerUserLabel}">
Line 269: <g:Label
text="{constants.maxAssignedVmsPerUser}"
addStyleNames="{style.maxAssignedVmsPerUserLabel}" />
Line 270: <d:InfoIcon
ui:field="editPoolMaxAssignedVmsPerUserIcon"
addStyleNames="{style.maxAssignedVmsPerUserIcon}" />
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 303: USB_NATIVE_SUPPORT_ONLY_AVAILABLE_ON_CLUSTER_LEVEL=Native USB support
is only available on cluster level 3.1 or higher.
Line 304: USB_LEGACY_NOT_SUPPORTED_ON_LINUX_VMS=Legacy USB support is not
available on Linux VMs.
Line 305: VM_POOL_CANNOT_CREATE_FROM_BLANK_TEMPLATE=VM-Pool must be based on
non-blank Template.
Line 306: VM_POOL_CANNOT_UPDATE_POOL_NOT_FOUND=Cannot edit VM-Pool properties -
VM-Pool not found.
Line 307: VM_POOL_NUMBER_OF_ASSIGNED_VMS_OUT_OF_RANGE=Number of max assigned
VMs per user must be between 1 and the current size of the pool.
I would call it VM-Pool also here (instead of "pool")
Line 308: ACTION_TYPE_FAILED_VM_TASKS_ARE_ALREADY_RUNNING=Cannot ${action}
${type}. There are already asynchronous running tasks, please retry later.
Line 309: VM_CANNOT_SUSPENDE_HAS_RUNNING_TASKS=Cannot suspend VM. VM has
asynchronous running tasks, please retry later.
Line 310: VM_CANNOT_SUSPEND_STATELESS_VM=Cannot suspend VM, VM is stateless.
Line 311: VM_CANNOT_SUSPEND_VM_FROM_POOL=Cannot suspend VM that belongs to a
VM-Pool.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 299: USB_NATIVE_SUPPORT_ONLY_AVAILABLE_ON_CLUSTER_LEVEL=Native USB support
is only available on cluster level 3.1 or higher.
Line 300: USB_LEGACY_NOT_SUPPORTED_ON_LINUX_VMS=Legacy USB support is not
available on Linux VMs.
Line 301: VM_POOL_CANNOT_CREATE_FROM_BLANK_TEMPLATE=VM-Pool must be based on
non-blank Template.
Line 302: VM_POOL_CANNOT_UPDATE_POOL_NOT_FOUND=Cannot edit VM-Pool properties -
VM-Pool not found.
Line 303: VM_POOL_NUMBER_OF_ASSIGNED_VMS_OUT_OF_RANGE=Number of max assigned
VMs per user must be between 1 and the current size of the pool.
same - plz use VM-Pool
Line 304: VM_POOL_CANNOT_ATTACH_TO_MORE_VMS_FROM_POOL=User is already attached
to maximum number of VMs from this VM-Pool.
Line 305: ACTION_TYPE_FAILED_VM_TASKS_ARE_ALREADY_RUNNING=Cannot ${action}
${type}. There are already asynchronous running tasks, please retry later.
Line 306: VM_CANNOT_SUSPENDE_HAS_RUNNING_TASKS=Cannot suspend VM. VM has
asynchronous running tasks, please retry later.
Line 307: VM_CANNOT_SUSPEND_STATELESS_VM=Cannot suspend VM, VM is stateless.
--
To view, visit http://gerrit.ovirt.org/14007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic92e98c87a72326b14a7ae002353cf720f3c9605
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <mbe...@redhat.com>
Gerrit-Reviewer: Martin Beták <mbe...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
