Allon Mureinik has posted comments on this change.

Change subject: restapi: Adding support for copy/move disk from disk collection.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
Line 101:         return doAction(VdcActionType.MoveDisks, params, action);
Line 102:     }
Line 103: 
Line 104:     @Override
Line 105:     public Response copy(Action action) {
Copy is only relevant for template disks - IIUC, this action here is 
meaningless.
Line 106:         validateParameters(action, "storageDomain.id|name");
Line 107:         Guid storageDomainId = getStorageDomainId(action);
Line 108:         Guid imageId = asGuid(getDisk().getImageId());
Line 109:         MoveOrCopyImageGroupParameters params =


--
To view, visit http://gerrit.ovirt.org/13973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I516341d3e033a94a997ac5320312e75a5ed1576c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to