Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: guide link opens with scrollbar ......................................................................
userportal,webadmin: guide link opens with scrollbar - Fixed the guide link not opening with a scrollbar causing users not to be able to scroll the guid. Change-Id: I006b68f2f8748f5621e86e8ffc07e33a03064bce Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=917970 Signed-off-by: Alexander Wels <aw...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/main/AbstractHeaderPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java 2 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/13996/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/main/AbstractHeaderPresenterWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/main/AbstractHeaderPresenterWidget.java index caf16f8..94711be 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/main/AbstractHeaderPresenterWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/main/AbstractHeaderPresenterWidget.java @@ -78,7 +78,7 @@ Configurator configurator = (Configurator) TypeResolver.getInstance().Resolve(Configurator.class); if (configurator.isDocumentationAvailable()) { String url = configurator.getDocumentationLibURL() + documentationGuidePath; - WebUtils.openUrlInNewWindow(windowName, url); + WebUtils.openUrlInNewWindow(windowName, url, WebUtils.OPTION_SCROLLBARS); } } })); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java index 2bb789f..8d829ca 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java @@ -4,7 +4,10 @@ import com.google.gwt.user.client.Window; public class WebUtils { - + /** + * constant for the 'scrollbars' window option. + */ + public static final String OPTION_SCROLLBARS = "scrollbars"; //$NON-NLS-1$ /** * Opens a link on another browser window. * @@ -13,8 +16,20 @@ * @param url * The URL to open */ - public static void openUrlInNewWindow(String name, String url) { - Window.open(url, name.replace(" ", "_"), null); //$NON-NLS-1$ //$NON-NLS-2$ + public static void openUrlInNewWindow(final String name, final String url) { + openUrlInNewWindow(name, url, null); + } + + /** + * Opens a link on another browser window. + * + * @param name The name of the new window + * @param url The URL to open + * @param options The options to pass to the window, option are described here:<br/> + * {@link https://developer.mozilla.org/en-US/docs/DOM/window.open} + */ + public static void openUrlInNewWindow(final String name, final String url, final String options) { + Window.open(url, name.replace(" ", "_"), options); //$NON-NLS-1$ //$NON-NLS-2$ } public static void openRelativeUrlInNewWindow(String name, String relativeUrl) { -- To view, visit http://gerrit.ovirt.org/13996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I006b68f2f8748f5621e86e8ffc07e33a03064bce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
