Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Classes that implements Comparator need to implement
Serializable
......................................................................
findbugs: Classes that implements Comparator need to implement Serializable
Change-Id: I6cac31263f151b2494845234f6ab21366b124181
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainsByTypeComparer.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
6 files changed, 30 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/13993/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainsByTypeComparer.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainsByTypeComparer.java
index 4091f08..504cce5 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainsByTypeComparer.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainsByTypeComparer.java
@@ -1,9 +1,10 @@
package org.ovirt.engine.core.bll.storage;
+import java.io.Serializable;
import java.util.Comparator;
import org.ovirt.engine.core.bll.*;
-public class StorageDomainsByTypeComparer implements Comparator<CommandBase> {
+public class StorageDomainsByTypeComparer implements Comparator<CommandBase>,
Serializable {
@Override
public int compare(CommandBase x, CommandBase y) {
return x.getStorageDomain().getStorageDomainType().getValue()
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
index 25d8951..fe53bee 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.core.common.utils;
+import java.io.Serializable;
import java.util.Comparator;
/**
@@ -18,7 +19,7 @@
* It is assumed that a string always begins with a nondigit sequence; if it
actually begins with a digit sequence, the
* behaviour is as if it started with an empty nondigit sequence.
*/
-public class LexoNumericComparator implements Comparator<String> {
+public class LexoNumericComparator implements Comparator<String>, Serializable
{
@Override
public int compare(String str1, String str2) {
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
index 2676958..86e217b 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.api.restapi.resource;
+import java.io.Serializable;
import java.util.Comparator;
import java.util.HashMap;
import java.util.List;
@@ -35,7 +36,7 @@
public class BackendAssignedPermissionsResource
extends AbstractBackendCollectionResource<Permission, permissions>
- implements AssignedPermissionsResource {
+ implements AssignedPermissionsResource, Serializable {
private Guid targetId;
private VdcQueryType queryType;
@@ -87,7 +88,7 @@
return inheritedPermissions;
}
- static class PermissionsComparator implements Comparator<permissions> {
+ static class PermissionsComparator implements Comparator<permissions>,
Serializable {
@Override
public int compare(permissions o1, permissions o2) {
String id1 = o1.getId().toString();
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
index 593f7e9..15ddb57 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.ui.uicommonweb;
+import java.io.Serializable;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
@@ -54,7 +55,7 @@
@SuppressWarnings("unused")
public final class Linq
{
- public static class AuditLogComparer implements Comparator<AuditLog>
+ public static class AuditLogComparer implements Comparator<AuditLog>,
Serializable
{
@Override
public int compare(AuditLog x, AuditLog y)
@@ -66,7 +67,7 @@
}
}
- public static class VmAndPoolByNameComparer implements Comparator
+ public static class VmAndPoolByNameComparer implements Comparator,
Serializable
{
@Override
public int compare(Object x, Object y)
@@ -96,7 +97,7 @@
* @param host
* @return
*/
- public static class VdsGroupByNameComparer implements Comparator<VDSGroup>
+ public static class VdsGroupByNameComparer implements
Comparator<VDSGroup>, Serializable
{
@Override
@@ -107,7 +108,7 @@
}
- public static class VmTemplateByNameComparer implements
Comparator<VmTemplate>
+ public static class VmTemplateByNameComparer implements
Comparator<VmTemplate>, Serializable
{
@Override
@@ -118,7 +119,7 @@
}
- public static class DiskImageByLastModifiedComparer implements
Comparator<DiskImage>
+ public static class DiskImageByLastModifiedComparer implements
Comparator<DiskImage>, Serializable
{
@Override
@@ -139,7 +140,7 @@
}
- public static class DiskImageByLastModifiedTimeOfDayComparer implements
Comparator<DiskImage>
+ public static class DiskImageByLastModifiedTimeOfDayComparer implements
Comparator<DiskImage>, Serializable
{
@Override
@@ -151,7 +152,7 @@
}
- public static class StorageDomainByNameComparer implements
Comparator<StorageDomain>
+ public static class StorageDomainByNameComparer implements
Comparator<StorageDomain>, Serializable
{
@Override
@@ -162,7 +163,7 @@
}
- public static class StorageDomainModelByNameComparer implements
Comparator<StorageDomainModel>
+ public static class StorageDomainModelByNameComparer implements
Comparator<StorageDomainModel>, Serializable
{
@Override
@@ -173,7 +174,7 @@
}
- public static class DiskByAliasComparer implements Comparator<Disk>
+ public static class DiskByAliasComparer implements Comparator<Disk>,
Serializable
{
@Override
@@ -197,7 +198,7 @@
}
- public static class DiskModelByAliasComparer implements
Comparator<DiskModel>
+ public static class DiskModelByAliasComparer implements
Comparator<DiskModel>, Serializable
{
@Override
public int compare(DiskModel x, DiskModel y)
@@ -221,7 +222,7 @@
}
}
- public static class NetworkByNameComparer implements Comparator<Network>
+ public static class NetworkByNameComparer implements Comparator<Network>,
Serializable
{
@Override
public int compare(Network x, Network y)
@@ -230,7 +231,7 @@
}
}
- public static class SanTargetModelComparer implements
Comparator<SanTargetModel>
+ public static class SanTargetModelComparer implements
Comparator<SanTargetModel>, Serializable
{
@Override
public int compare(SanTargetModel x, SanTargetModel y)
@@ -239,7 +240,7 @@
}
}
- public static class CaseInsensitiveComparer implements Comparator<String>
+ public static class CaseInsensitiveComparer implements Comparator<String>,
Serializable
{
@Override
@@ -250,7 +251,7 @@
}
- public static class DiskImageByCreationDateComparer implements
Comparator<DiskImage>
+ public static class DiskImageByCreationDateComparer implements
Comparator<DiskImage>, Serializable
{
@Override
@@ -271,7 +272,7 @@
}
- public static class RpmVersionComparer implements Comparator<RpmVersion> {
+ public static class RpmVersionComparer implements Comparator<RpmVersion>,
Serializable {
@Override
public int compare(RpmVersion x, RpmVersion y) {
@@ -279,7 +280,7 @@
}
}
- public static class SnapshotByCreationDateCommparer implements
Comparator<Snapshot>
+ public static class SnapshotByCreationDateCommparer implements
Comparator<Snapshot>, Serializable
{
@Override
@@ -290,7 +291,7 @@
}
- public static class StoragePoolByNameComparer implements
Comparator<storage_pool> {
+ public static class StoragePoolByNameComparer implements
Comparator<storage_pool>, Serializable {
@Override
public int compare(storage_pool x, storage_pool y) {
@@ -1262,7 +1263,7 @@
}
- public final static class RoleNameComparer implements Comparator<Role>{
+ public final static class RoleNameComparer implements Comparator<Role>,
Serializable {
@Override
public int compare(Role left, Role right) {
return left.getname().compareTo(right.getname());
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
index e83990e..c5a41f2 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.ui.uicommonweb.models.bookmarks;
+import java.io.Serializable;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
@@ -32,7 +33,7 @@
public class BookmarkListModel extends SearchableListModel
{
- private static class BookmarksComparator implements Comparator<Bookmark> {
+ private static class BookmarksComparator implements Comparator<Bookmark>,
Serializable {
@Override
public int compare(Bookmark o1, Bookmark o2) {
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
index af686c4..6cecf9d 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java
@@ -1,5 +1,6 @@
package org.ovirt.engine.ui.uicommonweb.models.resources;
+import java.io.Serializable;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
@@ -25,7 +26,7 @@
public class ResourcesModel extends SearchableListModel
{
- private static class ResourceComparator implements Comparator<VM> {
+ private static class ResourceComparator implements Comparator<VM>,
Serializable {
@Override
public int compare(VM o1, VM o2) {
--
To view, visit http://gerrit.ovirt.org/13993
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cac31263f151b2494845234f6ab21366b124181
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
