Barak Azulay has posted comments on this change. Change subject: agent: Perform string sanitization on messages ......................................................................
Patch Set 1: (2 inline comments) .................................................... File ovirt-guest-agent/VirtIoChannel.py Line 58: Line 59: Line 60: def _filter_xml_chars(u): Line 61: """ Line 62: Filter out restarted xml chars from unicode string. Not using s/restarted/restricted Line 63: Python's xmlcharrefreplace because it accepts '\x01', which Line 64: the spec frown upon. Line 65: Line 66: Set taken from http://www.w3.org/TR/xml11/#NT-RestrictedChar Line 62: Filter out restarted xml chars from unicode string. Not using Line 63: Python's xmlcharrefreplace because it accepts '\x01', which Line 64: the spec frown upon. Line 65: Line 66: Set taken from http://www.w3.org/TR/xml11/#NT-RestrictedChar The above line should appear in the __RESTRICTED_CHARS definition Line 67: """ Line 68: def mask_restricted(c): Line 69: if ord(c) in __RESTRICTED_CHARS: Line 70: return '?' -- To view, visit http://gerrit.ovirt.org/13608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I499a22e1572b55d1a3a4de7ce6f89ebb130861a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
