Roy Golan has posted comments on this change. Change subject: engine: VmTemplate cleanup (1/3) ......................................................................
Patch Set 3: FYI VmTemplateHandler doesn't work since the "permitted fields" lookup fits the java convention and the class is not. so your patch is extra important - please verify VmTemplateHandler behaviour BTW - the test class, VmTemplateHandlerTest didn't fail to verify it because it only checks "name" field... - if you add this test more fields it would be gr8 -- To view, visit http://gerrit.ovirt.org/13432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie40a67a3172fe6c812ee8fc0b8c0e170fb7b8e59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
