Yair Zaslavsky has posted comments on this change.
Change subject: Add support for OpenLDAP as domain provider
......................................................................
Patch Set 2: (1 inline comment)
Overall, good job.
I agree with Roy's comments.
Please also fix the manage domains script file and the man file
(engine-manage-domains.8)
Thanks!
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 186: String guidString = "";
Line 187:
Line 188: try {
Line 189: if (ldapProviderType.equals(LdapProviderType.ipa)) {
Line 190: String ipaUniqueId = (String)
sr.getAttributes().get("ipaUniqueId").get();
if else ... if else... is starting to be ugly.
Not mandatory + we should have thought about it before, we should have a map of
providerType (key) to name of attribute containing the user Id.
Line 191: guidString += ipaUniqueId;
Line 192: } else if
(ldapProviderType.equals(LdapProviderType.rhds)) {
Line 193: String nsUniqueId = (String)
sr.getAttributes().get("nsUniqueId").get();
Line 194: guidString +=
RHDSUserContextMapper.getGuidFromNsUniqueId(nsUniqueId);
--
To view, visit http://gerrit.ovirt.org/13829
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fa5c92088a34d8c3881ce839963a13fe9ca4f84
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Uwe Grawert <graw...@b1-systems.de>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Uwe Grawert <graw...@b1-systems.de>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
