Liron Ar has uploaded a new change for review. Change subject: core: TryBackToAllSnapshots - avoid attempt to remove illegal disks ......................................................................
core: TryBackToAllSnapshots - avoid attempt to remove illegal disks In change I8ee0e807 previewing a snapshot of vm with illegal disks was blocked, so we will never actually remove any illegal disks as if there were some - the action would have failed in the CDA phase. related to: Bug-Url: https://bugzilla.redhat.com/949624 Change-Id: Ie59bb1de3e9431998c9aa5269e3b65de8165dee9 Signed-off-by: Liron Aravot <lara...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/13965/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java index 16237e3..8c70670 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java @@ -131,7 +131,6 @@ getVm(), getCompensationContext()); snapshotsManager.addActiveSnapshot(newActiveSnapshotId, getVm(), getCompensationContext()); - snapshotsManager.removeAllIllegalDisks(previousActiveSnapshotId, getVm().getId()); //if there are no images there's no reason the save the compensation data to DB as //the update is being executed in the same transaction so we can restore the vm config and end the command. if (!images.isEmpty()) { -- To view, visit http://gerrit.ovirt.org/13965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie59bb1de3e9431998c9aa5269e3b65de8165dee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
