Liron Ar has uploaded a new change for review.
Change subject: core: prevent create snapshot when the vm has illegal disks.
......................................................................
core: prevent create snapshot when the vm has illegal disks.
When vm has illegal disks, prevent creating snapshot of it.
Change-Id: I1e6646fd2ead82c91f6660bc95c32ecaf046e266
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/13898/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
index d63baca..5ddf1f3 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
@@ -306,6 +306,7 @@
&& validate(vmValidator.vmNotDuringMigration())
&& validate(vmValidator.vmNotRunningStateless())
&& validate(vmValidator.vmNotIlegal())
+ &&
ImagesHandler.checkImagesIllegal(getReturnValue().getCanDoActionMessages(),
disksList)
&& ImagesHandler.PerformImagesChecks(
getReturnValue().getCanDoActionMessages(),
getVm().getStoragePoolId(),
--
To view, visit http://gerrit.ovirt.org/13898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e6646fd2ead82c91f6660bc95c32ecaf046e266
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
