Arik Hadas has uploaded a new change for review.
Change subject: core: CreateAllSnapshots..Command#executeVmCommand cleanup
......................................................................
core: CreateAllSnapshots..Command#executeVmCommand cleanup
Extract the section that build the parameters for the internal commands
of type CreateSnapshotCommand to a private method. that way, the
executeVmCommand method is shorter and more readable.
Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 16 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/13897/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
index d63baca..baf4d87 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
@@ -123,23 +123,10 @@
getCompensationContext());
for (DiskImage image : getDisksList()) {
- ImagesActionsParametersBase tempVar = new
ImagesActionsParametersBase(image.getImageId());
- tempVar.setDescription(getParameters().getDescription());
- tempVar.setSessionId(getParameters().getSessionId());
- tempVar.setQuotaId(image.getQuotaId());
- tempVar.setVmSnapshotId(newActiveSnapshotId);
- tempVar.setEntityId(getParameters().getEntityId());
- VdcActionType parentCommand =
getParameters().getParentCommand() != VdcActionType.Unknown ? getParameters()
- .getParentCommand() :
VdcActionType.CreateAllSnapshotsFromVm;
- tempVar.setParentCommand(parentCommand);
- ImagesActionsParametersBase p = tempVar;
-
- VdcActionParametersBase parrentParamsForTask =
getParametersForTask(parentCommand, getParameters());
- p.setParentParameters(parrentParamsForTask);
VdcReturnValueBase vdcReturnValue =
Backend.getInstance().runInternalAction(
VdcActionType.CreateSnapshot,
- p,
+ buildCreateSnapshotParameters(image,
newActiveSnapshotId),
ExecutionHandler.createDefaultContexForTasks(getExecutionContext()));
if (vdcReturnValue.getSucceeded()) {
@@ -153,6 +140,21 @@
setSucceeded(true);
}
+ private ImagesActionsParametersBase
buildCreateSnapshotParameters(DiskImage image, Guid snapshotId) {
+ VdcActionType parentCommand = getParameters().getParentCommand() !=
VdcActionType.Unknown ?
+ getParameters().getParentCommand() :
VdcActionType.CreateAllSnapshotsFromVm;
+
+ ImagesActionsParametersBase result = new
ImagesActionsParametersBase(image.getImageId());
+ result.setDescription(getParameters().getDescription());
+ result.setSessionId(getParameters().getSessionId());
+ result.setQuotaId(image.getQuotaId());
+ result.setVmSnapshotId(snapshotId);
+ result.setEntityId(getParameters().getEntityId());
+ result.setParentCommand(parentCommand);
+ result.setParentParameters(getParametersForTask(parentCommand,
getParameters()));
+ return result;
+ }
+
/**
* @return For internal execution, return the type from parameters,
otherwise return {@link SnapshotType#REGULAR}.
*/
--
To view, visit http://gerrit.ovirt.org/13897
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedcdcefe63c75927ed709faa9c1a64c5e983bc12
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
